Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure that custom parser is used if passed to process #1438

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

zth
Copy link
Contributor

@zth zth commented Mar 22, 2020

This ensures that a custom parser is used if passed to the server.

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #1438 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
+ Coverage   58.96%   58.98%   +0.01%     
==========================================
  Files          60       60              
  Lines        3022     3023       +1     
  Branches      796      796              
==========================================
+ Hits         1782     1783       +1     
  Misses       1194     1194              
  Partials       46       46
Impacted Files Coverage Δ
...raphql-language-service-server/src/GraphQLCache.ts 51.82% <100%> (+0.17%) ⬆️
...ql-language-service-server/src/MessageProcessor.ts 57.4% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6339ba7...6246abd. Read the comment docs.

@acao
Copy link
Member

acao commented Mar 22, 2020

@zth looks great!
maybe we should add a test for this?

@zth
Copy link
Contributor Author

zth commented Mar 22, 2020

I think tests would be great for sure, but there are no tests at that level right now from what I can see, and I think it'd be a bit involved to add it. Seeing as this fixes a feature that's currently broken, could we have this merged before tests are added?

@acao acao merged commit 5e098a4 into graphql:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants