fix: improve setSchema & schema loading, allow primitive schema #1648
Conversation
|
whoops, this is creating multiple worker threads in the example 😅 |
|
@cshaver excellent approach! and re: multiple workers that is expected! there should be a graphql, json, and editor language worker. not sure what the fourth is though? either way... i don't think it's creating multiple workers? i'll pull the repo and see for myself again, thanks for this, i was gonna try to get to this tonight before vacation but this is perfect timing! |
|
@cshaver can you do quick format fix or shall I? we delayed the camping trip til tomorrow so I'm gonna try to get a few releases out today! |
|
for whatever reason, if i remove
I'd like to close this PR once we can guarantee |
|
what is ultimately happening here I got it working! I also have Now, the API instance will hold onto the static schema if present as worker instances are re-created! |
- `api.setSchema()` allows primitive `GraphQLSchema` - `api.setSchema()` works standalone, without using `setSchemaConfig()`
acao
changed the title
…hql#1648) - allow null schema - `api.setSchema()` works on it's own, and static string is evaluated as a schema - `api.setSchema()` now allows `string | GraphQLSchema` Co-authored-by: Rikki <rikki.schulte@gmail.com>
Fixes #1621