Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom config baseDir, embedded fragment def offsets #1651

Merged
merged 3 commits into from
Aug 26, 2020
Merged

feat: custom config baseDir, embedded fragment def offsets #1651

merged 3 commits into from
Aug 26, 2020

Conversation

acao
Copy link
Member

@acao acao commented Aug 23, 2020

  • requires using createConnection() strategy
  • extension settings on server side for the first time
  • allow graphql-config loadConnfig() baseDir to be configured
  • properly calculate offsets for inline operation fragment defs

@acao
feat: custom baseDir, embedded frag def offsets
3d2b65a 
- requires using `createConnection()` strategy
- extension settings on server side for the first time
- allow graphql-config `loadConnfig()` `baseDir` to be configured
- properly calculate offsets for inline operation fragment defs
@acao acao mentioned this pull request Aug 23, 2020
Closed
15 tasks
@acao acao merged commit e8dc958 into graphql:main Aug 26, 2020
@acao acao deleted the feat/server-settings branch August 26, 2020 03:17
thenamankumar pushed a commit to thenamankumar/graphiql that referenced this pull request Aug 30, 2020
@acao @thenamankumar
feat: custom config baseDir, embedded fragment def offsets (graphql#1651
c5303cf 
)

- requires using createConnection() strategy
- extension settings on server side for the first time
- allow graphql-config loadConnfig() baseDir to be configured
- properly calculate offsets for inline operation fragment defs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@acao