Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lsp-server] [vscode-graphql] The language server should go into no-op mode when package.json is detected but doesn't contain graphql config #2820

Open
acao opened this issue Oct 16, 2022 · 0 comments
Labels
enhancement lsp-server graphql-language-service-server

Comments

@acao
Copy link
Member

acao commented Oct 16, 2022

Current Behavior (if applicable)

Currently, if package.json is present but no graphql config is present, the server will keep attempting to load the config on every change, and throwing a warning.
We want vscode-graphql to only load when graphql config is present, but package.json graphql config option as of 2.x or 3.x makes that difficult.

Desired Behavior

The LSP server should learn that graphql-config is not present for package.json and not try to load the config on every file change, and enter the no config present state where the server ignores events.

Perhaps we can even exit 0, so that the LSP server quits without the 5x attempted reloads, until an activation event triggers it again.

@acao acao added enhancement lsp-server graphql-language-service-server labels Oct 16, 2022
@acao acao changed the title [lsp-server] [vscode-graphql] The language server should exit when package.json is detected but doesn't contain graphql config [lsp-server] [vscode-graphql] The language server should go into no-op mode when package.json is detected but doesn't contain graphql config Oct 16, 2022
@acao acao mentioned this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement lsp-server graphql-language-service-server
Projects
None yet
Development

No branches or pull requests

1 participant