Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] Seeing a lot of act related warnings in tests #2892

Closed
1 of 4 tasks
TheMightyPenguin opened this issue Nov 11, 2022 · 2 comments · Fixed by #2903
Closed
1 of 4 tasks

[graphiql] Seeing a lot of act related warnings in tests #2892

TheMightyPenguin opened this issue Nov 11, 2022 · 2 comments · Fixed by #2903
Assignees

Comments

@TheMightyPenguin
Copy link
Contributor

TheMightyPenguin commented Nov 11, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

A few of the react unit tests are reporting warnings as they're not using act to wrap events that update the state. Also this is kind of tech debt, not sure what labels shout it have
image

Expected Behavior

We could wrap with act where necessary to get rid of these and remove some noise when running tests.

Steps To Reproduce

1. Run `yarn test Graphiql.spec` and you will see a lot of these (printing the minified source as well which adds even more noise)

Module pattern

  • graphiql-umd
  • graphiql-esm
  • graphiql-commonjs

Environment

- GraphiQL Version: latest
- OS: Mac OS 12.5
- Browser: Chrome 107
- Bundler:
- `react` Version: 17
- `graphql` Version: 16

Anything else?

No response

@jonathanawesome jonathanawesome self-assigned this Nov 11, 2022
@TheMightyPenguin TheMightyPenguin changed the title [graphiql] <title> [graphiql] Seeing a lot of act related warnings in tests Nov 11, 2022
@TheMightyPenguin
Copy link
Contributor Author

TheMightyPenguin commented Nov 11, 2022

@jonathanawesome you working on this one? If not I can help with it next week

@jonathanawesome
Copy link
Collaborator

@TheMightyPenguin I'm on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants