Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a full TodoApp-like example #14

Closed
ghost opened this issue Jul 3, 2015 · 7 comments
Closed

Provide a full TodoApp-like example #14

ghost opened this issue Jul 3, 2015 · 7 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jul 3, 2015

I've read the specs and saw that mutators are'nt quite well explained, but I have also seen that some sort of implementation seems to be provided.
https://github.com/graphql/graphql-js/blob/master/src/executor/executor.js#L229

Should maybe provide a test example for the mutator or is'nt intentionally provided in the spec yet?

@leebyron
Copy link
Contributor

leebyron commented Jul 3, 2015

I'm sure @dschafer can help explain a bit, and learn more from you on how we should improve our spec, tests and docs.

Here's a good place to start for our current test coverage:
https://github.com/graphql/graphql-js/blob/master/src/executor/__tests__/mutations.js

@ghost
Copy link
Author

ghost commented Jul 3, 2015

I think that maybe a simple todo-app comprhensive of mutators and all sort of things that graphqljs could offer could be nice!
(it could show query, query parameters, composition, mutators, etc...)

@leebyron
Copy link
Contributor

leebyron commented Jul 3, 2015

I agree. We're missing a few pieces to make that full demo as compelling as it could be, but we're definitely interested in working on. Stay tuned and thanks for the feedback!

@ghost ghost changed the title Provide a mutator test Provide a full TodoApp-like example Jul 3, 2015
@mathieumg
Copy link

I think that maybe a simple todo-app comprhensive of mutators and all sort of things that graphqljs could offer could be nice!

👍

@gyzerok
Copy link

gyzerok commented Jul 13, 2015

Any progress on this?

@leebyron
Copy link
Contributor

This is underway now, but may take some time to complete.

@dschafer
Copy link
Contributor

https://github.com/facebook/relay/tree/master/examples/todo contains a sample Todo app server, along with a Relay client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants