fix(incremental): properly initiate nested deferred grouped field sets #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
bug-without-early-execution
branch
from
2bc1cc0
to
64c3213
Compare
yaacovCR
changed the title
yaacovCR
force-pushed
the
bug-without-early-execution
branch
3 times, most recently
from
ff66d7d
to
16e7569
Compare
yaacovCR
changed the title
yaacovCR
force-pushed
the
bug-without-early-execution
branch
13 times, most recently
from
dc2cc66
to
2e49c99
Compare
yaacovCR
force-pushed
the
bug-without-early-execution
branch
3 times, most recently
from
ba99adb
to
7e2fe1e
Compare
when early execution is disabled, deferred grouped field sets should start immediately if and only if one of their deferred fragments is released as pending see: graphql/defer-stream-wg#84
yaacovCR
force-pushed
the
bug-without-early-execution
branch
from
7e2fe1e
to
21b4965
Compare
|
Closing in favor of #4140 |
yaacovCR
added a commit
that referenced
this pull request
Jul 11, 2024
Currently, when early execution is disabled, we still use the early execution logic to initiate execution groups, which may cause early initiation of non-pending execution groups. alternative to #4109, causes potentially stacking delays when combinations of shared and non-shared keys between sibling defers cause separate deferred grouped field sets for the same deferred fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when early execution is disabled, the shouldDefer logic has a subtle bug
see: graphql/defer-stream-wg#84 (reply in thread)
depends on #4112