Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions not found in official documentation #334

Closed
kingisaac95 opened this issue Jul 26, 2017 · 8 comments
Closed

Subscriptions not found in official documentation #334

kingisaac95 opened this issue Jul 26, 2017 · 8 comments

Comments

@kingisaac95
Copy link

I was writing an article on GraphQL subscriptions and wanted to point to the official documentation on graphql.org/learn/ but I noticed that the word "subscription" does not appear anywhere in the document.
So I thought I should raise this here.
Can I write a little documentation on it that could be added to the documentation? I know you guys are really doing a great job in making GraphQL more efficient and I want to contribute in any way I can.

@TOTBWF
Copy link
Contributor

TOTBWF commented Jul 26, 2017

For a detailed information on Subscriptions, look at the spec, specifically section 6.2.3.

@kingisaac95
Copy link
Author

Thanks @TOTBWF

@stubailo
Copy link
Contributor

stubailo commented Aug 1, 2017

@kingisaac95 here would be the place to add that! https://github.com/graphql/graphql.github.io/

I'm happy to review that, I wrote the original queries and mutations content :]

@kingisaac95
Copy link
Author

Thanks @stubailo. I'll reach out once I done with it.

@rokob
Copy link

rokob commented Nov 14, 2017

@TOTBWF That link doesn't work anymore, any reason subscriptions are no longer in the published spec?

@IvanGoncharov
Copy link
Member

@rokob http://facebook.github.io/graphql/ now points to lastest official release (see #364) which is predates subscriptions. You can see latest draft here: http://facebook.github.io/graphql/draft/ and it includes subscriptions.

P.S. I also was surprised until I checked publish.sh.

@jamesplease
Copy link

jamesplease commented Feb 19, 2018

I was a little confused by this, too. Luckily I found this issue! I opened a PR over in graphql/graphql.github.io#473 to remove this from the site for the time being.

@leebyron
Copy link
Collaborator

leebyron commented Oct 2, 2018

Closing in favor of graphql/graphql.github.io#584

@leebyron leebyron closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants