Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment directive overriding is underspecified #46

Closed
swolchok opened this issue Jul 13, 2015 · 3 comments
Closed

Fragment directive overriding is underspecified #46

swolchok opened this issue Jul 13, 2015 · 3 comments

Comments

@swolchok
Copy link

The Fragment Directives section says that "At runtime, the directives provided on a fragment spread override those described on the definition.", but "override" here is not sufficiently precise. Consider the following example:

query example { ...F @bar }
fragment F on Query @foo { some_field }

Is this equivalent to using both @foo and @bar or just @bar? (Presumably, "neither" and "just @foo" wouldn't be consistent with "override.") Does it matter if @bar and @foo have any kind of interaction in their effects?

@swolchok
Copy link
Author

Oh, there is a formalism FragmentSpreadDirectives that answers this. It could really be incorporated into the text better.

@leebyron leebyron reopened this Jul 14, 2015
@leebyron
Copy link
Collaborator

Leaving it open as a note to improve the text

@IvanGoncharov
Copy link
Member

@swolchok This section was removed in 1c38e6a:

In addition, this changes the specification of the @skip and @include directives to no longer allow their use on fragment directives (but are still allowed on fragment spreads and inline fragments). Because of this, a section on "merging fragment directives" is no longer useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants