Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for introspection field for spec information #212

Closed
dblandin opened this issue Jul 18, 2019 · 6 comments
Closed

RFC for introspection field for spec information #212

dblandin opened this issue Jul 18, 2019 · 6 comments

Comments

@dblandin
Copy link
Contributor

dblandin commented Jul 18, 2019

RFC for introspection field for spec information

assignee: @eapache & @andimarek
source: GraphQL Working Group Meeting 2019-07-03

@eapache
Copy link
Member

eapache commented Jul 18, 2019

Myself (@eapache) and @andimarek are working on this.

@dblandin dblandin changed the title Action Item: RFC for introspection field for spec information RFC for introspection field for spec information Jul 19, 2019
@eapache
Copy link
Member

eapache commented Aug 7, 2019

It's not ready for review, but I'm cutting a very rough first draft of the spec changes at https://github.com/eapache/graphql-spec/tree/custom-scalar-formats.

@benjie
Copy link
Member

benjie commented Aug 12, 2019

@eapache Do you think we should address versioning of these custom scalar specification documents? I think it's mostly beyond the scope of the spec, except maybe it should state that non-trivial ("functionally significant"?) changes to the specification document should result in a new specificationUri? E.g. JSON -> JSON5 would break previous parsers, so should require a new URI? Presumably this also would mean that changing the specificationUri would be a breaking change.

@eapache
Copy link
Member

eapache commented Aug 12, 2019

That's a really good point, I'll work that in.

@eapache
Copy link
Member

eapache commented Dec 5, 2019

This action item is effectively done, the RFC exists and is nicely in progress graphql/graphql-spec#635

@dblandin
Copy link
Contributor Author

This action item is effectively done, the RFC exists and is nicely in progress graphql/graphql-spec#635

Awesome! Going to go ahead and close this issue 🎉

@benjie benjie added this to To Do in Actions 2019-2020 pre May via automation Sep 4, 2020
@benjie benjie moved this from To Do to Done in Actions 2019-2020 pre May Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants