Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link rot http://graphql.org/users/ #305

Closed
hanachin opened this issue May 1, 2017 · 3 comments
Closed

link rot http://graphql.org/users/ #305

hanachin opened this issue May 1, 2017 · 3 comments

Comments

@hanachin
Copy link

hanachin commented May 1, 2017

The link More GraphQL Users in http://graphql.org returns 404 error
@pm-dev
Copy link
Contributor

pm-dev commented May 1, 2017

Most likely due to: #304

@wincent wincent mentioned this issue May 1, 2017
Merged
@wincent
Copy link
Contributor

wincent commented May 1, 2017

With bdf8894 this hopefully won't happen again.

@wincent wincent closed this as completed May 1, 2017
@wincent
Copy link
Contributor

wincent commented May 1, 2017

Thanks for the report, @hanachin.

Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this issue Aug 18, 2020
@wincent
Make sure that broken syntax blows up in Travis
157c7ed 
Will prevent issues like this from happening again:

- graphql#304
- graphql#305

Note that we fail loudly in `build` but not in `watch` (where we want to
give the user a chance to correct their error).

Tested by manually adding and removing syntax errors when doing `npm run
build` and `npm run watch`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wincent @hanachin @pm-dev