Lightstep dev mode #1956
Lightstep dev mode #1956
Conversation
ghost
self-assigned this
Dev satellites should always be localhost. This also primes the way to use private satellites
The lightstep dev container doesn't have a TLS endpoint by default. As such, the quickest way to get this working is to allow insecure transmission to the local container. Lng-term we should figure out how to get TLS active for this workflow
ghost
force-pushed
the
twunderlich/lightstep-dev-mode
branch
from
ecb64ee
to
f556e81
Compare
| # use the endpoint as a way to figure out if we're in local dev or not | ||
| if lightstep_endpoint == "ingest.lightstep.com:443": | ||
| is_endpoint_insecure = "false" | ||
| else: | ||
| is_endpoint_insecure = "true" |
There was a problem hiding this comment.
I guess I'm a bit confused here - do we actually care about local or not, or just if it's 443 (secure) or 80 (insecure)?
There was a problem hiding this comment.
If everything is going to the real Lightstep, do we have things namespaced or organized in such a way that we'll be able to differentiate traces from say, one engineer running tests locally and CI running tests in verify vs. in our staging environment?
There was a problem hiding this comment.
Just whether it's secure or not. I think I may switch this to just be passed in as a config instead.
There was a problem hiding this comment.
@christophermaier,
For devs, yes that should be specific to each engineer.
For the others, not yet. Right now everything should be staging. It looks like the right way to handle this is to have separate api keys, but I still need to finish testing that.
ghost
force-pushed
the
twunderlich/lightstep-dev-mode
branch
from
f556e81
to
297b406
Compare
ghost
force-pushed
the
twunderlich/lightstep-dev-mode
branch
from
478ba07
to
816963e
Compare
Codecov ReportBase: 40.96% // Head: 40.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
==========================================
- Coverage 40.96% 40.95% -0.01%
==========================================
Files 467 467
Lines 12562 12564 +2
Branches 23 23
==========================================
Hits 5146 5146
- Misses 7401 7403 +2
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Which issue does this PR correspond to?
Fixes https://github.com/grapl-security/issue-tracker/issues/1010
What changes does this PR make to Grapl? Why?
This adds the ability to run Lightstep in dev mode and get data into Lightstep
How were these changes tested?
Run the Lightstep docker container using the command from Lightstep
make up,Check that data makes it into the dev panel afterward