New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 4 components, and test on all three versions of Symfony. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
force-pushed
the
symfony-4
branch
from
November 29, 2017 23:52
35de480
to
9ecd131
Compare
3 similar comments
4 tasks
greg-1-anderson
force-pushed
the
symfony-4
branch
2 times, most recently
from
November 30, 2017 21:02
8721c51
to
71b1fc4
Compare
greg-1-anderson
force-pushed
the
symfony-4
branch
from
November 30, 2017 21:08
71b1fc4
to
dc6a045
Compare
greg-1-anderson
force-pushed
the
symfony-4
branch
from
November 30, 2017 21:12
dc6a045
to
1833cde
Compare
2 similar comments
greg-1-anderson
force-pushed
the
symfony-4
branch
from
November 30, 2017 21:27
1833cde
to
c13b264
Compare
greg-1-anderson
force-pushed
the
symfony-4
branch
from
November 30, 2017 21:34
c13b264
to
099db9f
Compare
greg-1-anderson
force-pushed
the
symfony-4
branch
from
November 30, 2017 21:44
099db9f
to
4a9ceba
Compare
Closed
…et Symfony 3 component in our default composer.lock file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 4.0.0 has been released!
This PR utilizes the composer-test-scenarios project to run the unit tests for this project on Symfony 2, Symfony 3 and Symfony 4. The highest/lowest test configurations may be selected for each version of Symfony that is tested. At the moment, only lowest testing is done for Symfony 2, and both current and highest testing are done for Symfony 3 and Symfony 4. This is easily adjusted in the travis test matrix.
In order to do highest/lowest testing, a derived composer.json / composer.lock file is kept for each test scenario. These are automatically updated on every
composer update
, and stored in thescenarios
directory.Testing on all versions of Symfony provides evidence (and confidence) that this project does in fact work in all of the scenarios advertised by its composer dependencies' version constraints.
If you want to do ad-hoc testing on a specific test scenario, just run
composer scenario symfony2
followed bycomposer test
.Symfony 4.0.0-stable is coming out tomorrow! Once that happens, the minimum-stability: RC stuff can be removed.I'm also going to rework the test strategy to get rid of the uglyif
block in theinstall:
section, but for now I just want to see this resolve and test correctly.