Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 4 components, and test on all three versions of Symfony. #11

Merged
merged 6 commits into from Dec 8, 2017

Conversation

greg-1-anderson
Copy link
Contributor

@greg-1-anderson greg-1-anderson commented Nov 29, 2017

Symfony 4.0.0 has been released!

This PR utilizes the composer-test-scenarios project to run the unit tests for this project on Symfony 2, Symfony 3 and Symfony 4. The highest/lowest test configurations may be selected for each version of Symfony that is tested. At the moment, only lowest testing is done for Symfony 2, and both current and highest testing are done for Symfony 3 and Symfony 4. This is easily adjusted in the travis test matrix.

In order to do highest/lowest testing, a derived composer.json / composer.lock file is kept for each test scenario. These are automatically updated on every composer update, and stored in the scenarios directory.

Testing on all versions of Symfony provides evidence (and confidence) that this project does in fact work in all of the scenarios advertised by its composer dependencies' version constraints.

If you want to do ad-hoc testing on a specific test scenario, just run composer scenario symfony2 followed by composer test.

Symfony 4.0.0-stable is coming out tomorrow! Once that happens, the minimum-stability: RC stuff can be removed.

I'm also going to rework the test strategy to get rid of the ugly if block in the install: section, but for now I just want to see this resolve and test correctly.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 35de480 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 9ecd131 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9ecd131 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9ecd131 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9ecd131 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 484c934 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8721c51 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 71b1fc4 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling dc6a045 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 1833cde on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1833cde on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1833cde on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c13b264 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 099db9f on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 4a9ceba on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f0b8045 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

…et Symfony 3 component in our default composer.lock file.
@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d3608ee on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3b9945a on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 24ccce9 on greg-1-anderson:symfony-4 into 78466e2 on grasmash:master.

@grasmash grasmash merged commit 3f45a3e into grasmash:master Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants