Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symfony/console from 'require' section. #5

Merged
merged 1 commit into from Aug 1, 2017

Conversation

greg-1-anderson
Copy link
Contributor

I'm doing some Drush work to use consolidation/config, which uses grasmash/yaml-expander.

Config has to be loaded very early in the bootstrap process. For various reasons, I'd like to limit the number of projects touched during this phase of the code.

grasmash/yaml-expander declares that it uses symfony/console, when in fact it does not. This PR removes symfony/console from the require section. This reduces the number of components loaded when installing with no-dev, but it has no affect on the packages loaded when including the require-dev packages, as satooshi/php-coveralls requires symfony/console.

I don't want to remove satooshi/php-coveralls from grasmash/yaml-expander, of course, but if I remove it on my local system, then symfony/console is removed, and the phpunit tests still pass.

So, while this PR has no affect on the actual operation of this project, for documentation purposes, I would prefer it if symfony/console were not listed in the require section. require-dev would be fine, although this is not necessary AFIK due to satooshi/php-coveralls.

@coveralls
Copy link

coveralls commented Jul 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 411574e on greg-1-anderson:no-console into 95f9c87 on grasmash:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 411574e on greg-1-anderson:no-console into 95f9c87 on grasmash:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 411574e on greg-1-anderson:no-console into 95f9c87 on grasmash:master.

@grasmash grasmash merged commit 720c54b into grasmash:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants