Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http://aspen.io/ gives internal error messages #513

Closed
techtonik opened this issue Sep 12, 2015 · 11 comments
Closed

http://aspen.io/ gives internal error messages #513

techtonik opened this issue Sep 12, 2015 · 11 comments

Comments

@techtonik
Copy link
Contributor

Pretty much every page after the main one is failing.

For example, http://aspen.io/api/website/

@chadwhitacre
Copy link
Contributor

screen shot 2015-09-12 at 8 26 10 pm

@techtonik
Copy link
Contributor Author

Traced to #297

@techtonik
Copy link
Contributor Author

@whit537 how often is OTP (one time python) vs PPP (per page python) optimization is needed? It is the first time I hear about the difference. Does it worth to maintain a third section with that?

If optimization is needed, the OTP can be achieved with some first_time flag passed to simplate code.

I liked that simplates could be plain HTML files. That simplifies transition from pure web apps and back.

@techtonik
Copy link
Contributor Author

  • And also, shouldn't we bump major aspen version for that backward-incompatible change?

@techtonik
Copy link
Contributor Author

  • And also, resources must have at least three pages is very confusing - simplates must have at least three sections - is it what it means?

@chadwhitacre
Copy link
Contributor

And also, shouldn't we bump major aspen version for that backward-incompatible change?

No. We're still pre-1.0. See #357 for the definition of 1.0.

@chadwhitacre
Copy link
Contributor

The fix for this ticket is simple grunt work: we need to add another section separator ([---]) to all simplates on the site.

@techtonik
Copy link
Contributor Author

Obligatory sections make simplates less attractive. Is there short explanation why it is not suitable anymore?

@pjz
Copy link
Contributor

pjz commented Sep 28, 2015

There's ambiguity if there's only two sections and no template header specified. We can DWIM if there's a template header (content type and/or renderer) specified, and we should do that - I'll work on a patch for that now, but if we're handed two sections with no template headers, it's unclear if the second page is meant to be python or a template using the default renderer and content type.

@pjz
Copy link
Contributor

pjz commented Sep 29, 2015

Fixed with #517

@pjz pjz closed this as completed Sep 29, 2015
@chadwhitacre
Copy link
Contributor

Confirmed fixed: http://aspen.io/api/website/.

!m @pjz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants