Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

clean up ui for managing my tips #25

Closed
chadwhitacre opened this issue Jun 6, 2012 · 10 comments
Closed

clean up ui for managing my tips #25

chadwhitacre opened this issue Jun 6, 2012 · 10 comments
Assignees

Comments

@chadwhitacre
Copy link
Contributor

@alexcouper
Copy link
Contributor

I tried this out and I was also surprised to see the list of suggested people disappear - might be worth keeping them around even if some have been selected.

@ghost ghost assigned alexcouper Jan 15, 2013
@alexcouper
Copy link
Contributor

I'm adding a test client to test POSTing to tip.json as part of this. It has taken me longer than I thought it would to get a client going. Unfortunately I'll have to park this until next week.

@chadwhitacre
Copy link
Contributor Author

@alexcouper Yeah, you probably discovered that Aspen's testing helpers are pretty much for GETs as they currently stand, eh?

May I add you to the Aspen team as well so you have access to that repo? Gittip and Aspen are going to need to grow together, and if you're interested I'd love to set you loose on Aspen as well.

@alexcouper
Copy link
Contributor

I think what i'll do (if it's OK), is add a testing module containing the POST-able client into gittip - and then notify someone in Aspen (possibly you ;) ) that it can be ported up the stack.

Just aware that I haven't got so much time left to do something worthwhile so don't want to get bogged down getting Aspen running w/ test suite etc...

@chadwhitacre
Copy link
Contributor Author

Of course, no problem, and thank you. :-)

@chadwhitacre
Copy link
Contributor Author

@alexcouper I refactored tip.json today so there is now a Participant.set_tip_to method in gittip.participant that encapsulates the logic, and the tip.json simplate handles only HTTP shenanigans. Not sure if that helps here. It sounds like you may be looking for something more like Selenium or capybara or PhantomJS (Ghost.py?).

@alexcouper
Copy link
Contributor

@whit537 I'll take a look at the refactoring this morning. What i'm after (and I think quite close to) is faking a POST into the system through changes to perform_request - so that we can get a response locally in the tests without running a web server. (simliar to how django's test client works really)

@chadwhitacre
Copy link
Contributor Author

@alexcouper Note that this UI will change once we land funds:

https://github.com/zetaweb/www.gittip.com/issues?milestone=29&state=open

Also, this UI will be given it's own page as part of the redesign:

https://github.com/zetaweb/www.gittip.com/issues?milestone=26&state=open

@chadwhitacre
Copy link
Contributor Author

I was so excited about the TestClient I didn't even notice that you actually addressed this ticket as well. :)

!m @alexcouper

@alexcouper
Copy link
Contributor

@whit537 - thanks for reticketing the other parts - which weren't looked at by me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants