-
Notifications
You must be signed in to change notification settings - Fork 308
clean up ui for managing my tips #25
Comments
I tried this out and I was also surprised to see the list of suggested people disappear - might be worth keeping them around even if some have been selected. |
I'm adding a test client to test POSTing to tip.json as part of this. It has taken me longer than I thought it would to get a client going. Unfortunately I'll have to park this until next week. |
@alexcouper Yeah, you probably discovered that Aspen's testing helpers are pretty much for GETs as they currently stand, eh? May I add you to the Aspen team as well so you have access to that repo? Gittip and Aspen are going to need to grow together, and if you're interested I'd love to set you loose on Aspen as well. |
I think what i'll do (if it's OK), is add a testing module containing the POST-able client into gittip - and then notify someone in Aspen (possibly you ;) ) that it can be ported up the stack. Just aware that I haven't got so much time left to do something worthwhile so don't want to get bogged down getting Aspen running w/ test suite etc... |
Of course, no problem, and thank you. :-) |
@alexcouper I refactored |
@whit537 I'll take a look at the refactoring this morning. What i'm after (and I think quite close to) is faking a POST into the system through changes to perform_request - so that we can get a response locally in the tests without running a web server. (simliar to how django's test client works really) |
@alexcouper Note that this UI will change once we land funds: https://github.com/zetaweb/www.gittip.com/issues?milestone=29&state=open Also, this UI will be given it's own page as part of the redesign: https://github.com/zetaweb/www.gittip.com/issues?milestone=26&state=open |
I was so excited about the TestClient I didn't even notice that you actually addressed this ticket as well. :) !m @alexcouper |
@whit537 - thanks for reticketing the other parts - which weren't looked at by me. |
It should also resort the list, probably after a 10 second delay or something.Reticketed as clicking a tip button should resort the list #568I also think we want to show "people you stopped tipping recently" so that accidental untips can be rectified easily.Reticketed as show "people you stopped tipping recently" #570.The text was updated successfully, but these errors were encountered: