Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Suggested donation banner populates incorrect amount in some other languages #4332

Closed
1 task done
mattbk opened this issue Feb 10, 2017 · 9 comments
Closed
1 task done

Comments

@mattbk
Copy link
Contributor

mattbk commented Feb 10, 2017

From FD:

I've donated to a project and then when your portal offered my to donate 0,40 to Gratipay I've clicked the button, but then my account shows u$s 4 dollar donation to Gratipay
May be it's a bug or I didn't undestand it. The BUTTON clearly displayed the number 0,40. Then I clicked it.

This works correctly for me. I think this may be a language issue around , vs . for currency? Screenshot submitted by FD user shows , is used.

English:
image

I am not sure how to change my language so I can test this myself.

notify

@chadwhitacre
Copy link
Contributor

@mattbk Changing language is in browser settings under "Content" for Chrome/FF, not sure about others.

@chadwhitacre
Copy link
Contributor

Well, "Advanced settings" > "Languages" in Chrome:

screen shot 2017-02-10 at 11 38 28 am

@mattbk
Copy link
Contributor Author

mattbk commented Feb 10, 2017

That works for you? Gratipay still shows up in English for me if I change to Italian or French in Chrome. I get the option to translate the page, but I know that's Google translating it, not the Transifex translations.

@mattbk
Copy link
Contributor Author

mattbk commented Feb 10, 2017

Stand by...

@mattbk
Copy link
Contributor Author

mattbk commented Feb 10, 2017

@mattbk
Copy link
Contributor Author

mattbk commented Feb 10, 2017

Problem confirmed, with Italian:

image

click US$ 0,30

image

and on /about/me/giving:

image

@mattbk mattbk changed the title Suggested donation banner may populate incorrect amount Suggested donation banner populates incorrect amount in some other languages Feb 10, 2017
@chadwhitacre
Copy link
Contributor

Maybe something to do with trailing_zeroes=False?

@chadwhitacre
Copy link
Contributor

PR ready to go in #4337.

@mattbk
Copy link
Contributor Author

mattbk commented Mar 2, 2017

Notified in Freshdesk.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants