This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Elsewhere: public.json -> %endpoint.json #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitelist-based: only public and charts are added in this commit.
|
Works as expected :3 |
rummik
added a commit
that referenced
this pull request
Mar 26, 2014
…generic Elsewhere: public.json -> %endpoint.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is whitelist-based: only
public.jsonandcharts.jsonare implemented in this PR, since they're the only ones that set the appropriate CORS headers.If we want others, I'd opt for making them a separate PR that adds CORS headers for them, as well.
NOTE: This PR is so that all of the things we add to the widgets JavaScript API can work with elsewhere.