Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Clean up how we handle sessions, cookies, and time zones #2385

Merged
merged 9 commits into from
Jun 11, 2014
Merged

Conversation

Changaco
Copy link
Contributor

I was going through https://github.com/gittip/www.gittip.com/branches yesterday and noticed an old issue-1499 branch, so I dusted it off and completed it.

This PR fixes #1499. It also resuscitates a change that was in #2041 but wasn't kept in #2332.

Please review, but don't merge yet, we need to land #2384 first.

@Changaco Changaco changed the title Only send a session cookie when it's actually needed Clean up how we handle sessions, cookies, and time zones May 13, 2014
@pjz
Copy link

pjz commented Jun 11, 2014

👍

@Changaco
Copy link
Contributor Author

Rebased on master and added 3 new commits. cc @pjz

@pjz
Copy link

pjz commented Jun 11, 2014

👍 LGTM! Merge it!

Changaco added a commit that referenced this pull request Jun 11, 2014
Clean up how we handle sessions, cookies, and time zones
@Changaco Changaco merged commit 407fdaf into master Jun 11, 2014
@Changaco Changaco deleted the fix-session branch June 11, 2014 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make sure we don't set session cookies for API requests
3 participants