-
Notifications
You must be signed in to change notification settings - Fork 309
Conversation
258a2a8
to
ff8ea82
Compare
At this point I'm planning to rebase this one a couple other PRs are landed first. See #3399 (comment). |
We want to turn off tipping (#3406) before we land this, because without this someone could tip a "patron-no-tips." |
This was a computed property of Participants that depended on goal.
@@ -0,0 +1,5 @@ | |||
BEGIN; | |||
|
|||
ALTER TABLE participants DROP COLUMN goal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whit537 - Are you sure we want to start dropping columns right now? Wouldn't it make sense to leave it all in there, and delete after we're done migrating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I see what you're doing - only deleting the columns that we won't find useful at all.
Tipping has been disabled, I'm merging this. |
!m @rohitpaulk |
Since users will no longer receive payments directly, there's no need for them to be able to publish a personal goal. Our goal implementation was half-baked anyway. If we want goals for teams we should implement them properly (a la Kickstarter, Patreon, Salt, etc.).
Incorporates #3402 and #3403.