This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
kill goal #3405
Merged
kill goal #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chadwhitacre
force-pushed
the
kill-goal
branch
2 times, most recently
from
258a2a8
to
ff8ea82
Compare
|
At this point I'm planning to rebase this one a couple other PRs are landed first. See #3399 (comment). |
|
We want to turn off tipping (#3406) before we land this, because without this someone could tip a "patron-no-tips." |
This was a computed property of Participants that depended on goal.
Merged
| @@ -0,0 +1,5 @@ | |||
| BEGIN; | |||
|
|
|||
| ALTER TABLE participants DROP COLUMN goal; | |||
There was a problem hiding this comment.
@whit537 - Are you sure we want to start dropping columns right now? Wouldn't it make sense to leave it all in there, and delete after we're done migrating?
There was a problem hiding this comment.
Okay, I see what you're doing - only deleting the columns that we won't find useful at all.
|
Tipping has been disabled, I'm merging this. |
|
!m @rohitpaulk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since users will no longer receive payments directly, there's no need for them to be able to publish a personal goal. Our goal implementation was half-baked anyway. If we want goals for teams we should implement them properly (a la Kickstarter, Patreon, Salt, etc.).
Incorporates #3402 and #3403.