Skip to content

Commit

Permalink
CHG: Remove grumphp because it's impossivel to mantain
Browse files Browse the repository at this point in the history
  • Loading branch information
gravataLonga committed Jan 18, 2022
1 parent e4f4b1b commit 2379f3f
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 33 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/php.yml
Expand Up @@ -46,11 +46,6 @@ jobs:
- name: Install dependencies
run: composer install --no-progress --no-suggest --prefer-dist --optimize-autoloader

- name: Run Grumphp
run: vendor/bin/grumphp run --no-ansi -n

This comment has been minimized.

Copy link
@drupol

drupol Jan 18, 2022

Contributor

Hey hi !

What is going on? Maybe I can help?

This comment has been minimized.

Copy link
@gravataLonga

gravataLonga Jan 18, 2022

Author Owner

oh hi! Glad did you see this commit, i'm getting trouble in making to work on PHP8.1 and using psr-11 on version 2.0 (https://github.com/php-fig/container/tree/2.0.2). On Grumphp there are so many dependecies not ready for php8.1.

If you can help me, i'm more than happy :(

This comment has been minimized.

Copy link
@drupol

drupol Jan 18, 2022

Contributor

Oh. I'm also using PHP 8.1 and I don't have any issue, besides somes harmless warnings.

Maybe @veewee have anything to say here?

This comment has been minimized.

Copy link
@veewee

veewee Jan 18, 2022

We recently released compatibility for PSR container v2.
But indeed : there are some downstream dependencies (opis closure, box, scoper, ...) not fully PHP 81 ready. There isn't much I can do about it, besides playing the waiting game.

If you have any specific issues regarding the GrumPHP repo itself, feel free to open up an issue.

This comment has been minimized.

Copy link
@gravataLonga

gravataLonga Jan 18, 2022

Author Owner

@veewee @drupol thank for help. I'm keeping eye on evolution on that.

This comment has been minimized.

Copy link
@drupol

drupol Jan 18, 2022

Contributor

Cheers mate, both of you!

env:
STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}

- name: Send PSALM data
run: vendor/bin/psalm --shepherd --stats
continue-on-error: true
Expand Down
3 changes: 3 additions & 0 deletions .scrutinizer.yml
Expand Up @@ -11,6 +11,9 @@ build:
php80:
environment:
php: 8.0
php81:
environment:
php: 8.1


filter:
Expand Down
8 changes: 4 additions & 4 deletions README.md
Expand Up @@ -15,10 +15,10 @@ Container implementation which follow PSR-11.

## Requirements

| PHP | VERSION |
| ------ | ----------- |
| 8.0 < | <= 1.6 |
| >= 8.0 | >= 1.7 |
| PHP | VERSION |
|---------| ----------- |
| 8.0 < | <= 1.6 |
| \>= 8.0 | >= 1.7 |

## Installation

Expand Down
1 change: 0 additions & 1 deletion composer.json
Expand Up @@ -19,7 +19,6 @@
"psr/container-implementation": "^1.0"
},
"require-dev": {
"drupol/php-conventions": "^3.0",
"infection/infection": "^0.18.0",
"phpunit/phpunit": "^9",
"vimeo/psalm": "^4.3.0"
Expand Down
23 changes: 0 additions & 23 deletions grumphp.yml.dist

This file was deleted.

4 changes: 4 additions & 0 deletions src/Container.php
Expand Up @@ -191,6 +191,7 @@ public function make($id, array $arguments = [])
*
* @return bool
*/
#[\ReturnTypeWillChange]
public function offsetExists($offset)
{
return $this->has($offset);
Expand All @@ -203,6 +204,7 @@ public function offsetExists($offset)
*
* @return mixed
*/
#[\ReturnTypeWillChange]
public function offsetGet($offset)
{
return $this->get($offset);
Expand All @@ -212,6 +214,7 @@ public function offsetGet($offset)
* @param string $offset
* @param mixed $value
*/
#[\ReturnTypeWillChange]
public function offsetSet($offset, $value): void
{
$this->factory($offset, $value);
Expand All @@ -222,6 +225,7 @@ public function offsetSet($offset, $value): void
*
* @return void
*/
#[\ReturnTypeWillChange]
public function offsetUnset($offset)
{
unset(
Expand Down

0 comments on commit 2379f3f

Please sign in to comment.