Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

Migrate to Gravatar profile REST API #25

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Migrate to Gravatar profile REST API #25

merged 6 commits into from
Jun 3, 2024

Conversation

wellyshen
Copy link
Contributor

@wellyshen wellyshen commented May 29, 2024 •
edited
Loading

Related to 107883-gh-Automattic/gravatar

Proposed Changes

  • Migrate to the new Gravatar profile REST API
  • Improve API error messages
  • Adjust the profileData event of the OnFetchProfileSuccess function
  • Adjust the error event of the onFetchProfileFailure function
  • Update the test examples
  • Update doc

Testing Instructions

截圖 2024-05-30 晚上9 21 45

@wellyshen wellyshen self-assigned this May 29, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems May 29, 2024
View reviewed changes
src/core.ts Dismissed Show dismissed Hide dismissed
@wellyshen wellyshen marked this pull request as ready for review May 30, 2024 13:23
lamosty
lamosty approved these changes Jun 3, 2024
View reviewed changes
Copy link

@lamosty lamosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out great!

:shipit:

@wellyshen wellyshen merged commit 8a5de6d into trunk Jun 3, 2024
4 checks passed
@wellyshen wellyshen deleted the migrate-to-rest-api branch June 3, 2024 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lamosty lamosty lamosty approved these changes

Assignees

@wellyshen wellyshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wellyshen @lamosty