add a heartbeat log per retry of a job #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
This adds a once per minute heartbeat log to be outputted for each retry
of a job.
-------
test strategy:
sleep.sh:
```sh
sleep 30
```
with `tickUnit := time.Second`...
```sh
go run cmd/gearcmd/*.go -cmd /home/vagrant/go/src/github.com/Clever/gearcmd/sleep.sh -name ticker-test -port 4730 -host <gearmand-server>
{"job":"ticker-test","level":"info","source":"gearcmd","title":"listening"}
{"function":"ticker-test","job_data":"{\"foo\":\"bar\"}","job_id":"214","level":"info","source":"gearcmd","title":"START"}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":1}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":2}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":3}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":4}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":5}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":6}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":7}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":8}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":9}
{"function":"ticker-test","job_id":"214","level":"info","source":"gearcmd","title":"heartbeat","try_number":0,"type":"gauge","unit":"1s","value":10}
```
natebrennand
force-pushed
the
IP-901-gearcmd-heartbeat
branch
from
2738d1f
to
7c7ea74
Compare
|
out of curiosity, why did we add the heartbeat logs? |
|
@agclever: mainly for simpler alerting purposes. Check the ticket in the branch name for more context. |
|
Thanks. The ticket was exactly the context I wanted :) |
|
💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a once per minute heartbeat log to be outputted for each retry
of a job.
test strategy:
sleep.sh:
with
tickUnit := time.Second...