This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
[6.1.x] Gravity report improvements #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardjkim
force-pushed
the
bernard/6.1.x/report-improvements
branch
2 times, most recently
from
93a29fe
to
474edf6
Compare
a-palchikov
approved these changes
Jun 26, 2020
lib/install/operation.go
Outdated
| rc, err := i.config.Operator.GetSiteReport(ctx, clusterKey) | ||
| rc, err := i.config.Operator.GetSiteReport(ctx, ops.GetClusterReportRequest{ | ||
| SiteKey: clusterKey, | ||
| Since: time.Duration(0), |
There was a problem hiding this comment.
nit: zero value will be the same if unspecified
lib/ops/opsservice/report.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // collectEtcdInfo collects etcd metrics. |
There was a problem hiding this comment.
collects etcd metrics and captures a snapshot of the data
bernardjkim
force-pushed
the
bernard/6.1.x/report-improvements
branch
from
48a8b9c
to
d6e3fc3
Compare
- Add since for to filter logs by time
- Add additional collectors
- reboot history
- uname
- swapon
- serf members
bernardjkim
force-pushed
the
bernard/6.1.x/report-improvements
branch
from
d6e3fc3
to
06ff9fd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a time filter to
gravity reportand adds a few more system collectors.last -xuname -aserf membersswapon -s(we have vmstat but wouldn't hurt)curl -s --tlsv1.2 --cacert /var/state/root.cert --cert /var/state/etcd.cert --key /var/state/etcd.key https://localhost:2379/metricsType of change
Linked tickets and other PRs
TODOs
Testing done
Verified additional collectors
Verified k8s logs are filtered by time
Verified journal logs are filtered by time