This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
(7.0) Disable source/dest check for instances #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-palchikov
approved these changes
Sep 29, 2020
bernardjkim
approved these changes
Sep 29, 2020
knisbet
approved these changes
Sep 29, 2020
This was referenced Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update our AWS autoscaler controller loop with additional responsibility to periodically check if any of the cluster instances have source/destination check enabled and disable it. The check should be disabled in AWS cloud integration mode.
Our autoscaler actually already disables this parameter for new instances that come up when it receives events from ASG, but it doesn't work for pre-existing instances or those created outside of auto-scaling groups.
I kept scaling in mind when adding this, there should not be any downsides in that regard because I'm using a single "describe instances" call with filters (once every 10 minutes) to get information specifically about instances that have that check enabled which should not be many.
Type of change
TODOs
Testing done
Provisioned instances using our terraform and made sure that gravity-site disables source/dest check. Also, manually enabled it back and made sure it was disabled again.