This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
[6.1.x] Add check for rollback phases in reverse order #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `requires` field to find dependent phases and check if all depedents have been rolled back if they have been started. * Collect and display phases that require rollback * Update phase state evaluation. If all subphases are either unstarted or rolled back, the phase is considered rolled back. * Update local phase state on remote rollback
a-palchikov
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the check for
gravity plan rollbackcommand. The check now ensures that phases of an operation are being rolled back in order. This check can be bypassed by providing the--forceflag.Type of change
Linked tickets and other PRs
TODOs
Testing done
Verify rollback phase fails if dependent phase is not rolled back
Verify rollback phase executes if
--forceflag is providedVerify latest phase can still be rolled back
Verify plan can be rolled back completely