This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Add CONTRIBUTING.md & CODE_OF_CONDUCT.md #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
approved these changes
Dec 4, 2019
|
#924 failed in jenkins because of https://github.com/gravitational/robotest/issues/154 (which I have an idea of how to fix), and this PR is inheriting the build status because the commit hash is identical. I retriggered, but it is hitting some sort of GH API throttling: As seen here: https://jenkins.gravitational.io/job/Gravity-PR-5.2/job/PR-924/3/console Once that clears up, I'd expect the CI to be green. |
wadells
commented
Dec 4, 2019
| Once you know you have a issue, make sure to fill out all sections of the | ||
| one of the templates at https://github.com/gravitational/gravity/issues/new/choose. | ||
|
|
||
| Gravity contributors will triage the issue shortly. |
There was a problem hiding this comment.
Is it safe to make this promise? I don't know what our issues/triage policy is currently.
wadells
commented
Dec 4, 2019
knisbet
approved these changes
Dec 4, 2019
While reviewing onboarding materials, @klizhentas noticed that the gravity repo was missing the code of conduct that was present in teleport. For consistency, adding it here. Addresses #923.
As I was looking at #923 (Gravity missing a code of conduct) I realised it didn't have any contributing info. Adding a CONTRIBUTING may help foster outsite engagement. Inspiration drawn from Teleport's CONTRIBUTING, mashed up with golang's.
This will help with discoverability, and tie the docs together more seamlessly.
Gravity uses the latter, as mentioned in: #925 (comment)
wadells
force-pushed
the
walt/code-of-conduct
branch
from
99a49dd
to
abaea0a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #923 by adding the code of conduct, and takes a stab at contribution guidelines. CONTRIBUTING felt appropriate to give discoverability to this info from the README.
Testing Done: