Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Sync kube-prometheus resources with 0.4.x upstream branch` #183

Merged
merged 14 commits into from Jul 21, 2020

Conversation

UnderGreen
Copy link
Contributor

Description

This PR is syncing our current setup of kube-prometheus with kube-prometheus release-0.4. For the time of applying this PR it was created from this commit. Release 0.4 was chosen based on kube-prometheus compatibility matrix with K8s 1.17.x.

Difference between upstream and our application:

  1. Prometheus version is used 2.19.2 as requested in community slack.
  2. Not all of the dashboards was added to our app, because I think they are useless for us.
  3. gravity related rules was moved to gravity-rules.yaml.

Some important changes in this PR.

  1. crds directory was renamed to kube-prometheus-setup because it contains more than just Custom Resource Definitions.
  2. Nodes and Pods dashboards were converted to the new dashboards json specification(Grafana 5+).
  3. Etcd related alerts/rules were deleted. I am going to add metrics right from etcd in another PR and delete them from satellite. Etcd 3 provides more metrics and they cover everything what we had to implement in satellite for etcd 2.

Type of change

  • New feature (non-breaking change which adds functionality)

TODOs

  • Perform manual testing for upgrades

Implementation

Testing done

  1. Fully tested installation
  2. kubectl top nodes/pods
  3. Dashboards are shown and have no empty graphs/panels.

Additional information

@UnderGreen UnderGreen requested a review from r0mant July 16, 2020 23:49
resources/install.sh Outdated Show resolved Hide resolved
@UnderGreen UnderGreen merged commit e762546 into version/7.0.x Jul 21, 2020
@UnderGreen UnderGreen deleted the sergei/sync_kube_prometheus_040 branch July 21, 2020 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants