-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Teleport update reconciliation on
status
updates (#34063)
* Fix Teleport update reconciliation on `status` updates This pull request addresses the issue where the Teleport operator reconciliation runs every time the operator updates the `status` subresource. This continuous reconciliation has led to an infinite loop, causing millions of reconciliations per minute. When an error occurs, such as having invalid role properties, the Operator updates the status and returns an error, which should trigger a rescheduled reconciliation with exponential backoff. The problem arises because the operator failed to enforce a resource generation change, resulting in an immediate trigger of a new reconciliation when the `status` field is updated. This pull request modifies the operator to avoid updating subresources and only trigger updates when there is a change in resource generation. Special thanks to @strideynet for confirming my hypothesis and giving the solution! Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * return proper status conditions on failures * enforce condition update on silentUpdateStatus --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
- Loading branch information
Showing
4 changed files
with
178 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters