Fix unresponsive terminal in Connect on Windows Server 2019 (#22971)

* Update node-pty to 0.11.0-beta29 * Do not use ConPTY
gravitational · Mar 13, 2023 · a5fa148 · a5fa148
1 parent 328c4e8
commit a5fa148
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/web/packages/teleterm/package.json b/web/packages/teleterm/package.json
@@ -29,7 +29,7 @@
   "homepage": "https://goteleport.com",
   "dependencies": {
     "emittery": "^1.0.1",
-    "node-pty": "0.10.0"
+    "node-pty": "0.11.0-beta29"
   },
   "devDependencies": {
     "@gravitational/build": "^1.0.0",

diff --git a/web/packages/teleterm/src/sharedProcess/ptyHost/ptyProcess.ts b/web/packages/teleterm/src/sharedProcess/ptyHost/ptyProcess.ts
@@ -54,6 +54,8 @@ export class PtyProcess extends EventEmitter implements IPtyProcess {
       // https://unix.stackexchange.com/questions/123858
       cwd: this.options.cwd || getDefaultCwd(this.options.env),
       env: this.options.env,
+      // Turn off ConPTY due to an uncaught exception being thrown when a PTY is closed.
+      useConpty: false,
     });
 
     this._setStatus('open');

diff --git a/yarn.lock b/yarn.lock
@@ -10530,7 +10530,7 @@ mute-stream@0.0.8:
   resolved "https://registry.yarnpkg.com/mute-stream/-/mute-stream-0.0.8.tgz#1630c42b2251ff81e2a283de96a5497ea92e5e0d"
   integrity sha512-nnbWWOkoWyUsTjKrhgD0dcz22mdkSnpYqbEjIm2nhwhuxlSkpywJmBo8h0ZqJdkp73mb90SssHkN4rsRaBAfAA==
 
-nan@^2.12.1, nan@^2.14.0:
+nan@^2.12.1, nan@^2.17.0:
   version "2.17.0"
   resolved "https://registry.yarnpkg.com/nan/-/nan-2.17.0.tgz#c0150a2368a182f033e9aa5195ec76ea41a199cb"
   integrity sha512-2ZTgtl0nJsO0KQCjEpxcIr5D+Yv90plTitZt9JBfQvVJDS5seMl3FOvsh3+9CoYWXf/1l5OaZzzF6nDm4cagaQ==
@@ -10693,12 +10693,12 @@ node-modules-regexp@^1.0.0:
   resolved "https://registry.yarnpkg.com/node-modules-regexp/-/node-modules-regexp-1.0.0.tgz#8d9dbe28964a4ac5712e9131642107c71e90ec40"
   integrity sha1-jZ2+KJZKSsVxLpExZCEHxx6Q7EA=
 
-node-pty@0.10.0:
-  version "0.10.0"
-  resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.10.0.tgz#c98d23967b076b35c9fb216c542a04d0b5db4821"
-  integrity sha512-Q65ookKbjhqWUYKmtZ6iPn0nnqNdzpm3YJOBmzwWJde/TrenBxK9FgqGGtSW0Wjz4YsR1grQF4a7RS5nBwuW9A==
+node-pty@0.11.0-beta29:
+  version "0.11.0-beta29"
+  resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.11.0-beta29.tgz#863bce79346b453ed199614686008d1a3220abe8"
+  integrity sha512-pkSldLXjjwFrGd3EJWI0Pu1jnxeQaW0P9i2EQtO2RaK/pZ22pf99lQ8OfptYTPK2oKZbkjwzqh05uJJ2krH9iA==
   dependencies:
-    nan "^2.14.0"
+    nan "^2.17.0"
 
 node-releases@^2.0.8:
   version "2.0.10"