Skip to content

Commit

Permalink
Remove unnecessary buffered reader wrapper (#39343)
Browse files Browse the repository at this point in the history
  • Loading branch information
zmb3 committed Mar 15, 2024
1 parent 20888bf commit ad59cd6
Showing 1 changed file with 2 additions and 20 deletions.
22 changes: 2 additions & 20 deletions tool/teleport/common/sftp.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,24 +80,6 @@ func (c compositeCh) Close() error {
return trace.NewAggregate(c.r.Close(), c.w.Close())
}

// bufferedReaderCloser wraps a [bufio.Reader] to make it an [io.ReadCloser].
type bufferedReaderCloser struct {
bufio.Reader

inner io.ReadCloser
}

func newBufferedReaderCloser(r io.ReadCloser) *bufferedReaderCloser {
return &bufferedReaderCloser{
Reader: *bufio.NewReader(r),
inner: r,
}
}

func (b *bufferedReaderCloser) Close() error {
return b.inner.Close()
}

type allowedOps struct {
write bool
path string
Expand Down Expand Up @@ -603,7 +585,7 @@ func onSFTP() error {
}

// Read the file transfer request for this session if one exists
bufferedReader := newBufferedReaderCloser(chr)
bufferedReader := bufio.NewReader(chr)
var encodedReq []byte
var fileTransferReq *srv.FileTransferRequest
for {
Expand All @@ -623,7 +605,7 @@ func onSFTP() error {
return trace.Wrap(err)
}
}
ch := compositeCh{bufferedReader, chw}
ch := compositeCh{io.NopCloser(bufferedReader), chw}

sftpEvents := make(chan *apievents.SFTP, 1)
h, err := newSFTPHandler(logger, fileTransferReq, sftpEvents)
Expand Down

0 comments on commit ad59cd6

Please sign in to comment.