Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ca_signature_algo configuration #12905

Closed
marcoandredinis opened this issue May 25, 2022 · 0 comments · Fixed by #13033
Closed

Remove ca_signature_algo configuration #12905

marcoandredinis opened this issue May 25, 2022 · 0 comments · Fixed by #13033
Labels
bug

Comments

@marcoandredinis
Copy link
Contributor

Expected behavior:
After the merge of #12674 we no longer use the following configuration:

teleport:
    ca_signature_algo: "rsa-sha2-512"

As we now rely upon the x/crypto package to choose the signing algorithm

Current behavior:

Bug details:
@marcoandredinis marcoandredinis mentioned this issue Jun 2, 2022
Merged
marcoandredinis added a commit that referenced this issue Jun 6, 2022
@marcoandredinis
Deprecate ca_signature_algo config (#13033)
306d011 
After the merge of #12674 we no longer use the following configuration:
```yaml
teleport:
    ca_signature_algo: "rsa-sha2-512"
```
As we now rely upon the `x/crypto` package to choose the signing algorithm (it defaults to `rsa-sha2-512`)

**Demo**
If we set `ca_signature_algo` (the value is irrelevant) and start `teleport` we get:
```shell
root@marco:/workspace# teleport start --debug
2022-06-02T09:33:58Z WARN             ca_signing_algo config option is deprecated and will be ignored, we'll always default to rsa-sha2-512. config/configuration.go:348
2022-06-02T09:33:58Z INFO             Generating new host UUID: b001159a-10e0-49a7-b4dc-61c73fbe9e42. service/service.go:726
...
```

Fixes #12905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate ca_signature_algo config gravitational/teleport
1 participant
@marcoandredinis