Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when local user conflicts with SAML user #1553

Closed
klizhentas opened this issue Jan 5, 2018 · 1 comment · Fixed by #1602
Closed

Better error message when local user conflicts with SAML user #1553

klizhentas opened this issue Jan 5, 2018 · 1 comment · Fixed by #1602
Assignees
Labels

Comments

@klizhentas
Copy link
Contributor

Description

Currently when local user exists with the same name as SAML/OIDC user and SAML user tries to login, user gets error "Failed to process SAML callback" which is not helpful, also no error in the logs.

Return more helpful error in this case.

@klizhentas klizhentas added the ux label Jan 5, 2018
@klizhentas klizhentas added this to the 2.5.0 milestone Jan 5, 2018
@klizhentas klizhentas self-assigned this Jan 5, 2018
@kontsevoy
Copy link
Contributor

kontsevoy commented Jan 5, 2018

Note: because it's a login event, this error must be logged into the audit log (it's ok to duplicate those with stderr). usually we're pretty good at this, just making sure it continues. the standard/recommended procedure for troubleshooting logins should be watching teleport's audit instaead of re-starting teleport with -d

klizhentas added a commit that referenced this issue Jan 16, 2018
This commit fixes #1553, fixes #1554 and makes sure
that audit log contains login success and failure entries
for OIDC, SAML, Github and local logins.
@klizhentas klizhentas mentioned this issue Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants