Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web UI has no favicon #24773

Closed
nklaassen opened this issue Apr 18, 2023 · 2 comments · Fixed by #24904
Closed

Web UI has no favicon #24773

nklaassen opened this issue Apr 18, 2023 · 2 comments · Fixed by #24904
Labels
bug test-plan-problem Issues which have been surfaced by running the manual release test plan ui

Comments

@nklaassen
Copy link
Contributor

Expected behavior:
The web UI has a favicon, as it did in previous versions (12.1.5 has one)

Current behavior:
No favicon

Bug details:

  • Teleport version: 13.0.0-dev.alpha.1
  • Recreation steps: open the proxy web ui
  • Debug logs: N/A
@nklaassen nklaassen added bug test-plan-problem Issues which have been surfaced by running the manual release test plan ui labels Apr 18, 2023
@nklaassen nklaassen mentioned this issue Apr 18, 2023
Closed
@zmb3
Copy link
Collaborator

zmb3 commented Apr 18, 2023

Hmm. Nothing seems to be calling useFavicon anymore (even on v11 and v12).

@ryanclark might this be related to vite?

@zmb3 zmb3 mentioned this issue Apr 20, 2023
Closed
@ryanclark ryanclark mentioned this issue Apr 20, 2023
Merged
@ryanclark
Copy link
Contributor

Hmm. Nothing seems to be calling useFavicon anymore (even on v11 and v12).

@ryanclark might this be related to vite?

Sorry for the delay - opened up PRs to fix

@zmb3 zmb3 closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug test-plan-problem Issues which have been surfaced by running the manual release test plan ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the favicon back gravitational/teleport
3 participants
@zmb3 @ryanclark @nklaassen