public_addr can no longer specify protocol

[Tener]

Expected behavior:

Prior to #23866 this used to work:

proxy_service:
  enabled: "true"
  public_addr:  ['https://teleport.example.com']

Now this needs to be:

proxy_service:
  enabled: "true"
  public_addr:  ['teleport.example.com']

Current behavior:

If https is part of the public_addr, these errors will be spammed:

2023-04-19T12:35:01+02:00 DEBU [PROXY:AGE] Failed to dial boson.tener.io:3080. error:[
ERROR REPORT:
Original Error: *net.OpError dial https: unknown network https
Stack Trace:
	github.com/gravitational/teleport/api@v0.0.0/client/alpn.go:139 github.com/gravitational/teleport/api/client.(*ALPNDialer).DialContext
	github.com/gravitational/teleport/lib/utils/proxy/proxy.go:102 github.com/gravitational/teleport/lib/utils/proxy.directDial.DialTimeout
	github.com/gravitational/teleport/lib/reversetunnel/agent_dialer.go:52 github.com/gravitational/teleport/lib/reversetunnel.(*agentDialer).DialContext
	github.com/gravitational/teleport/lib/reversetunnel/agent.go:364 github.com/gravitational/teleport/lib/reversetunnel.(*agent).connect
	github.com/gravitational/teleport/lib/reversetunnel/agent.go:319 github.com/gravitational/teleport/lib/reversetunnel.(*agent).Start
	github.com/gravitational/teleport/lib/reversetunnel/agentpool.go:314 github.com/gravitational/teleport/lib/reversetunnel.(*AgentPool).connectAgent
	github.com/gravitational/teleport/lib/reversetunnel/agentpool.go:273 github.com/gravitational/teleport/lib/reversetunnel.(*AgentPool).run
	github.com/gravitational/teleport/lib/reversetunnel/agentpool.go:257 github.com/gravitational/teleport/lib/reversetunnel.(*AgentPool).Start.func1

Notes:

I'm not sure why I put https:// in my test configuration, as all the docs for public_addr do not mention the protocol at all. That being said, it used to work, even if by accident, and no longer does.

Version: Teleport v13.0.0-alpha.1 git:v13.0.0-alpha.1-0-gf9b7326 go1.20.3

[greedy52]

@Tener is your auth and proxy in the same process?

Do you mind giving the above fix a try? or I can do more testing when I'm back next week.

cc @smallinsky

[Tener]

@Tener is your auth and proxy in the same process?

Do you mind giving the above fix a try? or I can do more testing when I'm back next week.

cc @smallinsky

Yes, auth and proxy were in the same process.

The fix works like a charm, thank you.