Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect permissions are set for x11SockDir #24819

Closed
GrosQuildu opened this issue Apr 19, 2023 · 0 comments · Fixed by #34613
Closed

Incorrect permissions are set for x11SockDir #24819

GrosQuildu opened this issue Apr 19, 2023 · 0 comments · Fixed by #34613
Assignees
Labels

Comments

@GrosQuildu
Copy link

The OpenNewXServerListener methods creates x11SockDir directory with 1777 permissions, instead of 0o1777 - it is decimal vs octal problem. The permissions that are now set are 1777 = 0o3361.

// Create /tmp/.X11-unix if it doesn't exist (such as in CI)
if err := os.Mkdir(x11SockDir(), 1777); err != nil && !errors.Is(err, os.ErrExist) {
return nil, Display{}, trace.Wrap(err)
}

Moreover, the StickyBit should be set with the os.ModeSticky to work on all platforms. E.g., the 0o1777 won't set the StickyBit on OSX.

@GrosQuildu GrosQuildu added the bug label Apr 19, 2023
zmb3 added a commit that referenced this issue Nov 15, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
zmb3 added a commit that referenced this issue Nov 15, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
zmb3 added a commit that referenced this issue Nov 15, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
github-actions bot pushed a commit that referenced this issue Nov 15, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
github-actions bot pushed a commit that referenced this issue Nov 15, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
github-actions bot pushed a commit that referenced this issue Nov 15, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
We were passing decimal 1777 instead of octal.

Closes #24819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants