Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify creating moderated sessions for leaf nodes #25557

Closed
capnspacehook opened this issue May 3, 2023 · 6 comments · Fixed by #32420
Closed

clarify creating moderated sessions for leaf nodes #25557

capnspacehook opened this issue May 3, 2023 · 6 comments · Fixed by #32420

Comments

@capnspacehook
Copy link
Contributor

capnspacehook commented May 3, 2023

If a role specifies that created sessions must be moderated with require_session_join and a user containing that role attempts to connect to a leaf node, it should not require moderation, unless the mapped leaf roles also require moderation. This should be documented.

@capnspacehook capnspacehook added bug test-plan-problem Issues which have been surfaced by running the manual release test plan server-access labels May 3, 2023
@zmb3
Copy link
Collaborator

zmb3 commented May 3, 2023

Web UI, tsh, or both?

@capnspacehook
Copy link
Contributor Author

Both

@capnspacehook capnspacehook added documentation and removed test-plan-problem Issues which have been surfaced by running the manual release test plan labels May 3, 2023
@capnspacehook
Copy link
Contributor Author

This is actually expected behavior and should be documented. Unless the mapped roles of the leaf cluster require session moderation, created sessions for leaf nodes will succeed.

@capnspacehook capnspacehook changed the title creating moderated sessions for a leaf node is not enforced clarify creating moderated sessions for leaf nodes May 3, 2023
@zmb3 zmb3 removed the bug label May 3, 2023
@zmb3
Copy link
Collaborator

zmb3 commented May 17, 2023

This is not just for moderated sessions and is just how RBAC role mapping works across trusted clusters.

The docs cover this here: https://goteleport.com/docs/architecture/trustedclusters/#role-mapping

I'll leave it up to @ptgott or @alexfornuto to determine whether or not we need to expand this.

@alexfornuto
Copy link
Contributor

I think the flowchart linked explains role mapping pretty well for what it is, but that in general that image is not the best way to document this feature. All the content in that image can't be parsed by our search engine, and won't come up in results... and in general it's difficult to read.

I think we could improve this bit of documentation by:

  • Replacing the chart with a smaller one with less copy in it, then detailing the flow underneath with text.
  • While we're in there we can use the OP as an example of how role mapping behaves in that given scenario.

Thoughts @ptgott & @lsgunn-teleport ?

@lsgunn-teleport
Copy link
Contributor

I've started working a complete rewrite of this section (in part, I had to learn about trusted root and leaf clusters to address gravitational/docs#379 and https://github.com/gravitational/teleport-private/issues/130#top).
Right now I'm lumping it all in one page, but it might make sense to split it into a few shorter pages in a future iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment