Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move teleport builds off ubuntu 18.04 #26856

Closed
wadells opened this issue May 24, 2023 · 6 comments
Closed

Move teleport builds off ubuntu 18.04 #26856

wadells opened this issue May 24, 2023 · 6 comments
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements release-engineering security Security Issues

Comments

@wadells
Copy link
Contributor

wadells commented May 24, 2023

Ubuntu 18:04 is reaching the end of its life in ~1 week on 2023-05-31:

https://ubuntu.com/blog/18-04-end-of-standard-support

We currently use 18.04 in the following buildboxes:

https://github.com/gravitational/teleport/blob/v13.0.2/build.assets/Dockerfile#L99

https://github.com/gravitational/teleport/blob/v13.0.2/build.assets/Dockerfile-fips#L73

These workflows will need to be moved to a supported distro.

@wadells wadells added security Security Issues feature-request Used for new features in Teleport, improvements to current should be #enhancements release-engineering labels May 24, 2023
@wadells
Copy link
Contributor Author

wadells commented May 24, 2023

We moved most workflows to centos:7 in #13913. However, this wasn't possible with Teleport Connect, as it depends on a node version which doesn't support centos:7. Per #21724:

Our builders currently use Node v16 which EOL is September 11th, 2023.
The main problem with the upgrade is that we use CentOS 7 image for Linux pipelines, which Node v18 does not support.

Further discussion in a slack thread here: https://gravitational.slack.com/archives/C08HF8E9F/p1683130098612679

@wadells
Copy link
Contributor Author

wadells commented May 24, 2023

I believe Dockerfile-fips is no longer needed after #14062

@zmb3
Copy link
Collaborator

zmb3 commented May 25, 2023

However, this wasn't possible with Teleport Connect, as it depends on a node version which doesn't support centos:7

My understanding is that the new node version that we're trying to upgrade to doesn't support centos:7, but the version we are on today does.

@wadells
Copy link
Contributor Author

wadells commented May 25, 2023

My understanding is that the new node version that we're trying to upgrade to doesn't support centos:7, but the version we are on today does.

@zmb I believe this change recently happened. I'm not super familiar with this toolchain, but here is my logic:

Am I missing something?

Would we roll back #26072 to make have Teleport Connect share the centos:7 buildbox and make sure it continues to work on older linuxes?

@gzdunek
Copy link
Contributor

gzdunek commented May 26, 2023

The confusing part is that we talk about the two versions of node.
The first is installed on our build boxes (v16.18) <- this is the one we want to upgrade
The second one is embedded in Electron (Electron v24 uses node v18).

We were afraid that having a mismatch in versions can cause some problems, but we didn't find any issues during testing. Also we can't rollback the PR you mentioned, because Electron v22 goes EOL on May 30 (so we are forced to drop support for older linuxes).

My understanding is that the new node version that we're trying to upgrade to doesn't support centos:7, but the version we are on today does.

This is correct, but it is only about the version installed on build boxes.

@wadells
Copy link
Contributor Author

wadells commented Jun 14, 2023

This was largely addressed by #27175 and #27497. The remaining cleanup was completed in #26859.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements release-engineering security Security Issues
Projects
None yet
Development

No branches or pull requests

3 participants