Use Ubuntu latest for the buildbox #27497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we really want latest though? What kind of impact will that have on reproducible builds? |
codingllama
reviewed
Jun 6, 2023
After moving the Connect to a separate Docker image #27175 we're able to use the latest ubuntu LTS on our build image. We're not using this image to produce any releases (only CI runs), so updating the image will have no effect on our releases.
jakule
force-pushed
the
jakule/buildbox-use-latest
branch
from
73467a2
to
2ee21ba
Compare
|
I reverted |
No impact. This image is not used for any builds now. |
codingllama
approved these changes
Jun 6, 2023
|
Thanks for doing this. Just the fact that we can update it, if the need arises or if it becomes convenient to do so, is excellent. |
zmb3
approved these changes
Jun 7, 2023
public-teleport-github-review-bot
bot
removed request for
marcoandredinis,
hugoShaka and
rosstimothy
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving the Connect to a separate Docker image #27175 we're able to use the latest ubuntu LTS on our build image. We're not using this image to produce any releases (only CI runs), so updating the image will have no effect on our releases.
I also remove the TODO for v13.
Contributes to #26856