Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERROR: creating resources of type "windows_desktop" is not supported #27106

Closed
webvictim opened this issue May 30, 2023 · 2 comments · Fixed by #27192
Closed

ERROR: creating resources of type "windows_desktop" is not supported #27106

webvictim opened this issue May 30, 2023 · 2 comments · Fixed by #27192
Labels
bug desktop-access tctl tctl - Teleport admin tool ux

Comments

@webvictim
Copy link
Contributor

Expected behavior: tctl edit windows_desktop/<uuid> (or tctl create -f windows_desktop.yaml) should work to edit entries added via non_ad_hosts.

Commands like tctl update windows_desktop/<uuid> --set-labels=environment=test would also be useful to avoid inline editing.

Essentially a better supported method to set labels on Windows hosts would be useful.

Current behavior:

# tctl edit windows_desktop/<uuid>
[make changes, save and exit editor]
ERROR: creating resources of type "windows_desktop" is not supported

# tctl update windows_desktop/<uuid> --set-labels=environment=test
ERROR: updating resources of type "windows_desktop" is not supported, supported are: "remote_cluster"

Bug details:

  • Teleport version: 13.0.3
@webvictim webvictim added bug ux tctl tctl - Teleport admin tool desktop-access labels May 30, 2023
@zmb3
Copy link
Collaborator

zmb3 commented May 30, 2023

We should probably support tctl create, but I'm not sure about using tctl edit to set labels. I think they will just get overwritten on the next heartbeat.

@webvictim
Copy link
Contributor Author

The concern here is mostly about having a dynamic way to insert hosts and set labels on them without requiring the use of the non_ad_hosts section of the windows_desktop_service configuration and a restart of the agent on every change. I think not supporting tctl edit is OK as long as there's a reliable way to create/update/delete hosts without editing the config file and restarting the service.

zmb3 added a commit that referenced this issue May 31, 2023
@zmb3
tctl: allow creating desktops from YAML file
bd4a7b1 
To date: we have supported registering desktops in a few ways:

1. By discovering them from LDAP
2. By listing "static hosts" in the configuration file
3. Via our API
   https://github.com/gravitational/teleport/tree/master/examples/desktop-registration

This extends tctl to support creating a desktop from a YAML resource
definition, which provides an alternative for those who want more
control over the name and labels of their desktops, but don't want to
write and maintain an integration using our API.

Note: this also makes it possible to `tctl edit` an existing desktop,
but we do not recommend doing so if the desktop was created via methods
1 or 2 above, as any changes will be overwritten on the next heartbeat.

Closes #27106
@zmb3 zmb3 mentioned this issue May 31, 2023
Merged
@zmb3 zmb3 closed this as completed in 9753c01 Jun 1, 2023
github-actions bot pushed a commit that referenced this issue Jun 1, 2023
@zmb3
tctl: allow creating desktops from YAML file
28f6bc8 
To date: we have supported registering desktops in a few ways:

1. By discovering them from LDAP
2. By listing "static hosts" in the configuration file
3. Via our API
   https://github.com/gravitational/teleport/tree/master/examples/desktop-registration

This extends tctl to support creating a desktop from a YAML resource
definition, which provides an alternative for those who want more
control over the name and labels of their desktops, but don't want to
write and maintain an integration using our API.

Note: this also makes it possible to `tctl edit` an existing desktop,
but we do not recommend doing so if the desktop was created via methods
1 or 2 above, as any changes will be overwritten on the next heartbeat.

Closes #27106
zmb3 added a commit that referenced this issue Jun 1, 2023
@zmb3
tctl: allow creating desktops from YAML file
dd9a0ca 
To date: we have supported registering desktops in a few ways:

1. By discovering them from LDAP
2. By listing "static hosts" in the configuration file
3. Via our API
   https://github.com/gravitational/teleport/tree/master/examples/desktop-registration

This extends tctl to support creating a desktop from a YAML resource
definition, which provides an alternative for those who want more
control over the name and labels of their desktops, but don't want to
write and maintain an integration using our API.

Closes #27106
@zmb3 zmb3 mentioned this issue Jun 1, 2023
Merged
zmb3 added a commit that referenced this issue Jun 2, 2023
@zmb3
tctl: allow creating desktops from YAML file (#27250)
76ac605 
To date: we have supported registering desktops in a few ways:

1. By discovering them from LDAP
2. By listing "static hosts" in the configuration file
3. Via our API
   https://github.com/gravitational/teleport/tree/master/examples/desktop-registration

This extends tctl to support creating a desktop from a YAML resource
definition, which provides an alternative for those who want more
control over the name and labels of their desktops, but don't want to
write and maintain an integration using our API.

Note: this also makes it possible to `tctl edit` an existing desktop,
but we do not recommend doing so if the desktop was created via methods
1 or 2 above, as any changes will be overwritten on the next heartbeat.

Closes #27106
zmb3 added a commit that referenced this issue Jun 2, 2023
@zmb3
tctl: allow creating desktops from YAML file (#27251)
be248ee 
To date: we have supported registering desktops in a few ways:

1. By discovering them from LDAP
2. By listing "static hosts" in the configuration file
3. Via our API
   https://github.com/gravitational/teleport/tree/master/examples/desktop-registration

This extends tctl to support creating a desktop from a YAML resource
definition, which provides an alternative for those who want more
control over the name and labels of their desktops, but don't want to
write and maintain an integration using our API.

Closes #27106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug desktop-access tctl tctl - Teleport admin tool ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tctl: allow creating desktops from YAML file gravitational/teleport
2 participants
@webvictim @zmb3