Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReviewAccessRequest RPC does not respect Machine ID Role Impersonation #33028

Closed
Tracked by #29048
strideynet opened this issue Oct 5, 2023 · 1 comment · Fixed by #33375
Closed
Tracked by #29048

ReviewAccessRequest RPC does not respect Machine ID Role Impersonation #33028

strideynet opened this issue Oct 5, 2023 · 1 comment · Fixed by #33375
Assignees

Comments

@strideynet
Copy link
Contributor

Expected behavior:

When interacting with the ReviewAccessRequest RPC and my identity is in a state of role impersonation, whether or not I am able to review a request should be based on the roles I have impersonated rather than the roles my user directly holds.

Current behavior:

The ReviewAccessRequest RPC fetches the users roles and evaluates based on those rather than the roles currently associared with the identity. This prevents Machine ID bot credentials from being able to review access requests as part of our plugins.

Suggested fix:

Following discussion, we will add support for evaluating role impersonation correctly. The code will ensure that the impersonated roles are a subset of the users impersonatable roles - this prevents recursive impersonation via access requests.

@strideynet strideynet added the bug label Oct 5, 2023
@strideynet strideynet self-assigned this Oct 5, 2023
@strideynet
Copy link
Contributor Author

Part of #29048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant