Allow Bots to submit access request reviews #33375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
commented
Oct 12, 2023
fspmarshall
approved these changes
Oct 12, 2023
|
Manually tested at a553671 |
…b.com:gravitational/teleport into strideynet/machine-id-approve-access-requests
|
@fspmarshall if you don't mind taking a look now I've included tests, that'd be greatly appreciated :) |
rosstimothy
approved these changes
Oct 13, 2023
public-teleport-github-review-bot
bot
removed the request for review
from EdwardDowling
fspmarshall
approved these changes
Oct 13, 2023
…b.com:gravitational/teleport into strideynet/machine-id-approve-access-requests
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Oct 16, 2023
* Guesstimate towards a solution * Remove unrelated comment * Roughly try a different way of supporting this * Revert line that was necessary to change * Change signature of exported func to match client * Fix test invocation * Add test for Bot reviewing access request * Fix missing err check in test * Use single context * Use client rather than unexported method in test * Check err before defer
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Guesstimate towards a solution * Remove unrelated comment * Roughly try a different way of supporting this * Revert line that was necessary to change * Change signature of exported func to match client * Fix test invocation * Add test for Bot reviewing access request * Fix missing err check in test * Use single context * Use client rather than unexported method in test * Check err before defer
smallinsky
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Guesstimate towards a solution * Remove unrelated comment * Roughly try a different way of supporting this * Revert line that was necessary to change * Change signature of exported func to match client * Fix test invocation * Add test for Bot reviewing access request * Fix missing err check in test * Use single context * Use client rather than unexported method in test * Check err before defer
smallinsky
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Guesstimate towards a solution * Remove unrelated comment * Roughly try a different way of supporting this * Revert line that was necessary to change * Change signature of exported func to match client * Fix test invocation * Add test for Bot reviewing access request * Fix missing err check in test * Use single context * Use client rather than unexported method in test * Check err before defer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33028
Modifies the access request submit RBAC to respect impersonated roles when the user is a bot. This is necessary as bot certificates always use role impersonation.