Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child processes should be killed when Teleport session ends #4469

Closed
aelkugia opened this issue Oct 7, 2020 · 1 comment · Fixed by #19817
Closed

Child processes should be killed when Teleport session ends #4469

aelkugia opened this issue Oct 7, 2020 · 1 comment · Fixed by #19817
Labels
c-m Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements robustness Resistance to crashes and reliability server-access
Milestone
Runway Milestone

Comments

@aelkugia
Copy link
Contributor

aelkugia commented Oct 7, 2020

Feature Request

Teleport should act like SSH, and kill any child processes when the connection is closed (intentionally or not).

Motivation

Processes are not completely cleaned up when a Teleport session ends. Most cases are when the connection ends abruptly, such as a network drop, but customer did mentioned they did not confirm that that is always the case.

The majority of these cases are when the engineers are running 'rails console' (effectively an interactive ruby interpreter that's loaded all the libraries and dependencies of a project), because it consumes a lot of memory, and there may be multiple old consoles running on a machine.

  • Unable to 'kill ' the process, and have to do 'kill -9 ' to get it to terminate.
  • 'service teleport reload' will successfully kill the child processes (once all teleport connections have ended).
  • The process's parent has been reassigned to pid1
  • strace reveals that the main process is FUTEX_WAITing for another thread to return. strace on that thread reveals that it's waiting from input from stdin.

(Internal reference, more details in Zendesk ticket: #1951)

Who's it for?

OSS User, Pro, Enterprise
@aelkugia aelkugia added feature-request Used for new features in Teleport, improvements to current should be #enhancements c-m Internal Customer Reference labels Oct 7, 2020
@aelkugia aelkugia added this to the Runway Milestone milestone Oct 7, 2020
@zmb3 zmb3 added robustness Resistance to crashes and reliability server-access labels Jul 24, 2022
@rosstimothy rosstimothy mentioned this issue Jan 5, 2023
Closed
@zmb3
Copy link
Collaborator

zmb3 commented Feb 1, 2023

@jakule you may have fixed this recently when investigating the agent forwarding tests.

No rush, but when you have a moment can you check whether this still occurs with your latest changes?

@jakule jakule mentioned this issue Feb 1, 2023
Merged
jakule added a commit that referenced this issue Feb 24, 2023
@jakule
Terminate the local shell when a session closes #19817
391e655 
When a client sends an SSH session before the shell process ends, Teleport sends the SIGKILL signal to the subprocess. This causes the still-leaving shell to be resigned to PID 1 and live forever.
This PR tried to stop the terminal first before killing the subprocess to prevent the terminal from living forever.

Closes #13335
Closes #6245
Closes #4469
@jakule jakule closed this as completed in 7ccf2f2 Feb 24, 2023
jakule added a commit that referenced this issue Feb 24, 2023
@jakule
Terminate the local shell when a session closes #19817 (#19817)
d81a5d4 
When a client sends an SSH session before the shell process ends, Teleport sends the SIGKILL signal to the subprocess. This causes the still-leaving shell to be resigned to PID 1 and live forever.
This PR tried to stop the terminal first before killing the subprocess to prevent the terminal from living forever.

Closes #13335
Closes #6245
Closes #4469
jakule added a commit that referenced this issue Feb 24, 2023
@jakule
Terminate the local shell when a session closes #19817 (#19817)
7f8ce93 
When a client sends an SSH session before the shell process ends, Teleport sends the SIGKILL signal to the subprocess. This causes the still-leaving shell to be resigned to PID 1 and live forever.
This PR tried to stop the terminal first before killing the subprocess to prevent the terminal from living forever.

Closes #13335
Closes #6245
Closes #4469
jakule added a commit that referenced this issue Feb 24, 2023
@jakule
Terminate the local shell when a session closes #19817 (#19817)
7bd7283 
When a client sends an SSH session before the shell process ends, Teleport sends the SIGKILL signal to the subprocess. This causes the still-leaving shell to be resigned to PID 1 and live forever.
This PR tried to stop the terminal first before killing the subprocess to prevent the terminal from living forever.

Closes #13335
Closes #6245
Closes #4469
jakule added a commit that referenced this issue Mar 9, 2023
@jakule
Terminate the local shell when a session closes #19817 (#19817) (#22231)
d33e74b 
When a client sends an SSH session before the shell process ends, Teleport sends the SIGKILL signal to the subprocess. This causes the still-leaving shell to be resigned to PID 1 and live forever.
This PR tried to stop the terminal first before killing the subprocess to prevent the terminal from living forever.

Closes #13335
Closes #6245
Closes #4469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-m Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements robustness Resistance to crashes and reliability server-access
Projects
None yet
Milestone
Runway Milestone
Development

Successfully merging a pull request may close this issue.

Terminate the local shell when a session closes gravitational/teleport
2 participants
@zmb3 @aelkugia