bumps RotateTrustedClusters timeout from 30 to 60 sec
#13687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure increasing timeouts actually helps us unless we can prove the correct behavior is happening and it's just happening a little too late. Looks like the test run on this PR itself timed out. Looking at the integration tests, nearly all of the app access tests take 10 seconds or more. If we want to prevent timeouts, maybe it's best we start there and see if we can simplify them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the failures documented in #13569 appear to be run-of-the-mill timeout failures. Presuming there's been a recent increase in this failure, the hypothesis in #13568 (comment) could be the underlying cause. Until that's investigated, bumping the timeout may give us more successful integration test runs.