[v9] Correctly handle Firestore pagination with DocumentID cursors #13757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
approved these changes
Jun 22, 2022
Joerger
approved these changes
Jun 22, 2022
Merged
xacrimon
force-pushed
the
bot/backport-13017-branch/v9
branch
from
7a44399
to
cfe144a
Compare
r0mant
requested changes
Aug 29, 2022
There was a problem hiding this comment.
@xacrimon We know that upgrading crypto/ssh (which we've done in v10+) breaks old SSH clients that do not support the new signature algorithms. Can we find a way to fix this Firestore issue without bumping crypto/ssh in v9 branch?
|
@r0mant I've reverted the package update changes as they weren't actually needed for the bug fix to work. The crypto version is now unchanged from the PR target. |
somethingnew2-0
approved these changes
Sep 7, 2022
|
We’re currently on the v9 release for our deployment of Teleport in GCP with the Firestore backend. Can this be merged and released? |
r0mant
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #13017 to branch/v9