[v9] Improve error msg when client fails to auth in Teleport #13835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
force-pushed
the
marco/v9/connection_error_invalid_certs
branch
from
f464368
to
e735761
Compare
hatched
approved these changes
Jun 24, 2022
marcoandredinis
force-pushed
the
marco/v9/connection_error_invalid_certs
branch
3 times, most recently
from
0c8a1dc
to
00e841b
Compare
hatched
approved these changes
Jun 24, 2022
marcoandredinis
force-pushed
the
marco/v9/connection_error_invalid_certs
branch
3 times, most recently
from
18b1e0e
to
fb873a6
Compare
|
@probakowski friendly ping 🙏 |
When the client connects to teleport with invalid credentials (eg expired ones) it will retry multiple times until the context deadline is reached. When it happens, we receive the generic error: context deadline exceeded. However, we can ask for the latest connection error, one which will give us more information on why it happened. To ask for this extra error we need to add the following grpc.DialOption: grpc.WithReturnConnectionError() After doing this, we will get the errors that happenned when trying to connect to the grpc Server. This should help us debug possible connection problems. We had to refactor a little bit the way we handle the parallel connection attempts to receive all the connection errors from the multiple flows.
marcoandredinis
force-pushed
the
marco/v9/connection_error_invalid_certs
branch
from
fb873a6
to
461878f
Compare
probakowski
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #12677 to branch/v9