[v10] Alias support for tsh (#13305, #14931)
#14919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* aliases are read from global and user configs. * we prevent Kingpin from terminating `tsh`; we handle parsing errors better. * added support for `TELEPORT_DEBUG` env variable, changed how logging is initialized. * debugging aliases is possible via `TELEPORT_DEBUG=1` env variable; `--debug` is ineffective as it comes into play too late. * if alias definition calls `tsh`, we call the `Run()` function directly instead of spawning fresh `tsh`; this improves the UX. * alias loops are detected and a proper error is shown. * all flags are made repeatable; if only one value for a given flag is possible, the last instance of the flag will be effective. Co-authored-by: Marek Smoliński <marek@goteleport.com>
github-actions
bot
added
the
tsh
|
Note: this PR is on hold as implementation is being discussed #14931. |
smallinsky
approved these changes
Jul 29, 2022
r0mant
approved these changes
Aug 5, 2022
* Document `tsh` aliases usage. * Rename: `TSH_ALIAS` => `TSH_UNALIAS` * Support $TSH variable in alias definitions. * Document `$TSH` in tsh aliases. * Apply suggestions from code review Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Roman Tkachenko <roman@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Tener
changed the title
tsh (#13305)tsh (#13305, #14931)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #13305 and #14931 to v10
tsh; we handle parsing errors better.TELEPORT_DEBUGenv variable, changed how logging is initialized.TELEPORT_DEBUG=1env variable;--debugis ineffective as it comes into play too late.tsh, we call theRun()function directly instead of spawning freshtsh; this improves the UX.Document tsh aliases usage. Change implementation details. (#14931)
Document
tshaliases usage.Rename:
TSH_ALIAS=>TSH_UNALIASSupport $TSH variable in alias definitions.
Document
$TSHin tsh aliases.