[v10] Fix the behavior of tsh mfa add --allow-passwordless
#15137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport
tsh
GavinFrazar
approved these changes
Aug 2, 2022
|
Friendly ping @r0mant ? |
r0mant
approved these changes
Aug 3, 2022
codingllama
force-pushed
the
bot/backport-15013-branch/v10
branch
4 times, most recently
from
bf2d4a9
to
cad4a48
Compare
codingllama
force-pushed
the
bot/backport-15013-branch/v10
branch
from
cad4a48
to
439694f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--allow-passwordlessflag was ignored when set, which makes tsh donon-passwordless registrations. This causes all sorts of confusing behavior.
I'm taking the chance to also add some additional logging to webauthncli.
Backport #15013 to branch/v10