[v10] desktop access: try using system DNS resolver first #15255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, we assumed that the best way to resolve auto-discovered desktops would be to make a DNS query of the configured LDAP server, since the Linux box running Teleport would likely not be domain joined and may have separate DNS configuration. It turns out to be pretty common to deploy dedicated LDAP servers behind a VIP or other frontend, in which case we fail to resolve the desktop's IP even though the system resolver would have worked just fine. Instead, make a standard DNS query using the system's default settings first, and fall back to the LDAP server only if that query fails. Fixes #15154
github-actions
bot
requested review from
espadolini,
ibeckermayer and
rosstimothy
espadolini
approved these changes
Aug 5, 2022
ibeckermayer
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #15180 to branch/v10