[v10] auditlog: fix panic during concurrent streams of the same session #15360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
audit-log
rosstimothy
approved these changes
Aug 10, 2022
xacrimon
approved these changes
Aug 11, 2022
…5348) The code attempts to wait on an existing download if one is already in progress rather than starting a concurrent download of the same session. If this code path runs, we incorrectly defer a call to a nil function, triggering a panic. This bug was introduced in #7360. In some cases, an auth server can see a response from the uploader with an empty session ID. If this is the case, skip emitting the session end and upload events, as there's no action to take. This scenario can happen when multiple auth servers are running upload completers and working on the same uploads simultaneously.
zmb3
force-pushed
the
zmb3/v10-fix-auditlog-stream-panic
branch
from
7e7d858
to
b4a55d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code attempts to wait on an existing download if one is already
in progress rather than starting a concurrent download of the same
session. If this code path runs, we incorrectly defer a call to a
nil function, triggering a panic.
This bug was introduced in #7360.
In some cases, an auth server can see a response from the uploader
with an empty session ID. If this is the case, skip emitting the
session end and upload events, as there's no action to take.
This scenario can happen when multiple auth servers are running
upload completers and working on the same uploads simultaneously.
Forward port of #15348